Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test spec demonstrating bug reported in #22428 #22429

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 77 additions & 0 deletions system-tests/projects/plugin-run-events-multiple/cypress.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
/* eslint-disable no-console */
const EventEmitter = require('events')

class EventBugFix {
constructor (on_reference) {
this.emitter = new EventEmitter()
this.on_reference = on_reference
this.proxied_events = [
'before:run',
'after:run',
'before:spec',
'after:spec',
]

this.proxied_events.forEach((event) => {
on_reference(event, (...args) => {
this.emitter.emit(event, ...args)
})
})
}
on (event, ...args) {
if (this.proxied_events.indexOf(event) !== -1) {
this.emitter.on(event, ...args)
} else {
this.on_reference(event, ...args)
}
}
}

module.exports = {
'fixturesFolder': false,
'e2e': {
'supportFile': false,
setupNodeEvents (on, config) {
// Run test with RUN_MULTIPLE_PASS=true to show test pass
if (process.env.RUN_MULTIPLE_PASS) {
const _bugFix = new EventBugFix(on)

on = _bugFix.on.bind(_bugFix)
}

on('before:run', (runDetails) => {
console.log('before:run first handler')
})

on('before:run', (runDetails) => {
console.log('before:run second handler')
})

on('after:run', (results) => {
console.log('after:run first handler')
})

on('after:run', (results) => {
console.log('after:run second handler')
})

on('before:spec', (spec) => {
console.log('before:spec first handler')
})

on('before:spec', (spec) => {
console.log('before:spec second handler')
})

on('after:spec', (spec, results) => {
console.log('after:spec first handler')
})

on('after:spec', (spec, results) => {
console.log('after:spec second handler')
})

return config
},
},
}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
it('is true', () => {})
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
it('is true', () => {})
25 changes: 25 additions & 0 deletions system-tests/test/plugin_run_events_multiple_spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import systemTests, { expect } from '../lib/system-tests'

describe('e2e plugin run events', () => {
systemTests.setup()
const events = ['before:run', 'after:run', 'before:spec', 'after:spec']

events.forEach((event) => {
systemTests.it(`${event} supports multiple event listeners`, {
browser: 'electron',
project: 'plugin-run-events-multiple',
spec: '*',
snapshot: false,
config: {
video: false,
},
async onRun (exec) {
const res = await exec()
const normOut = systemTests.normalizeStdout(res.stdout)

expect(normOut).to.contain(`${event} first handler`)
expect(normOut).to.contain(`${event} second handler`)
},
})
})
})