-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build Cypress for darwin-arm64 #20686
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Wow, even on a toy project with just 2 specs (both failing, but that's not the point): # m1
yarn cypress run --component --project ~/code/dump/basic-cypress 7.50s user 2.32s system 138% cpu 7.097 total
# x64
yarn cypress run --component --project ~/code/dump/basic-cypress 36.86s user 4.51s system 197% cpu 20.970 total Around 5x speedup! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking over the code, it's mostly just configuration - basically the kind of thing I was expect.
I tried the pre-release and it's really quick. I posted some numbers in another comment, but I'm seeing about a 5x speedup on a few toy projects! ⚡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it out on my M1 and it works like a charm ✨
Works great on my M1 🎉 |
The pre-release works like a charm! thanks! |
I've just updated to 10.2.0 and everything is SO MUCH FASTER. Before, I had to wait ~15 sec to open cypress, open the browser, listing specs... now it's literally instantaneous! Thanks @flotwig for your work! :) |
User facing changelog
Additional details
How has the user experience changed?
People can now use a native build which should provide superior performance to running via Rosetta.
Benchmarking highlights:
Full benchmark data: https://docs.google.com/spreadsheets/d/1SHA2KgTywB6rNgPx8GfdlwoG9JDyWioo4QGo2QPK93M/edit#gid=0
Steps to test
npm i
inside of an M1 machine with or without Rosetta.PR Tasks
cypress-documentation
? docs(guides): add darwin/linux arm64 to OS requirements cypress-documentation#4568type definitions
?