Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix rerunning multidomain tests #18090

Merged
merged 2 commits into from
Sep 21, 2021

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Sep 14, 2021

User facing changelog

N/A - Multidomain WIP

Additional details

Issue was caused by the secondary domain bridge iframe not existing and not being re-created on rerun.

Previously kept state in the driver for which domains were visited and had their bridge iframes already loaded (so they're not needlessly re-created between tests), but the iframes get cleared out between test runs, so it's better to let the runner, which controls the iframes, essentially keep that state instead.

PR Tasks

  • Have tests been added/updated?
  • N/A Has the original issue or this PR been tagged with a release in ZenHub?
  • N/A Has a PR for user-facing changes been opened in cypress-documentation?
  • N/A Have API changes been updated in the type definitions?
  • N/A Have new configuration options been added to the cypress.schema.json?

@chrisbreiding chrisbreiding requested a review from a team as a code owner September 14, 2021 13:39
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 14, 2021

Thanks for taking the time to open a PR!

@chrisbreiding chrisbreiding requested review from flotwig and jennifer-shehane and removed request for a team September 14, 2021 13:39
@cypress
Copy link

cypress bot commented Sep 14, 2021



Test summary

8610 2 104 4Flakiness 6


Run details

Project cypress
Status Failed
Commit a5e0ace
Started Sep 14, 2021 3:01 PM
Ended Sep 14, 2021 3:12 PM
Duration 10:59 💡
OS Linux Debian - 10.9
Browser Multiple

View run in Cypress Dashboard ➡️


Failures

commands/actions/type_spec.js Failed
1 ... > element
e2e/focus_blur_spec.js Failed
1 intercept blur methods correctly > focus area

Flakiness

commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
2 network stubbing > intercepting request > can intercept utf-8 request bodies without crashing
commands/xhr_spec.js Flakiness
1 src/cy/commands/xhr > abort > aborts xhrs currently in flight
dom/visibility_spec.ts Flakiness
1 ... > has `opacity: 0`
cypress/proxy-logging-spec.ts Flakiness
1 Proxy Logging > request logging > fetch log shows resource type, url, method, and status code and has expected snapshots and consoleProps
This comment includes only the first 5 flaky tests. See all 6 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this test hangs when it does not include the code from this PR. Manually works on rerunning multidomain tests.

@chrisbreiding chrisbreiding merged commit 416aabe into feature-multidomain Sep 21, 2021
@chrisbreiding chrisbreiding deleted the issue-18043-multidomain-fix-rerun branch April 5, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants