-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix rerunning multidomain tests #18090
Merged
chrisbreiding
merged 2 commits into
feature-multidomain
from
issue-18043-multidomain-fix-rerun
Sep 21, 2021
Merged
chore: Fix rerunning multidomain tests #18090
chrisbreiding
merged 2 commits into
feature-multidomain
from
issue-18043-multidomain-fix-rerun
Sep 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for taking the time to open a PR!
|
chrisbreiding
requested review from
flotwig and
jennifer-shehane
and removed request for
a team
September 14, 2021 13:39
jennifer-shehane
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that this test hangs when it does not include the code from this PR. Manually works on rerunning multidomain tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
N/A - Multidomain WIP
Additional details
Issue was caused by the secondary domain bridge iframe not existing and not being re-created on rerun.
Previously kept state in the driver for which domains were visited and had their bridge iframes already loaded (so they're not needlessly re-created between tests), but the iframes get cleared out between test runs, so it's better to let the runner, which controls the iframes, essentially keep that state instead.
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?