Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear() and type('{selectall}{del}') behavior difference. #14498

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

sainthkh
Copy link
Contributor

User facing changelog

clear() and type('{selectall}{del}') behave differently when they were used against elements that contain text inputs.

Additional details

  • Why was this change necessary? => They didn't follow the documentation.
  • What is affected by this change? => If an element is big and its center is outside the viewport, it would now return "center hidden" error, rather than "invalid element".
  • Any implementation details to explain? => If the given element is not a text input, it now checks the actionability and uses the $elToClick just like cy.type().

How has the user experience changed?

N/A

PR Tasks

  • Have tests been added/updated?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 12, 2021

Thanks for taking the time to open a PR!

@sainthkh sainthkh marked this pull request as ready for review January 12, 2021 09:00
@jennifer-shehane
Copy link
Member

Looks like we forgot to merge this :/

@jennifer-shehane jennifer-shehane merged commit eee7488 into cypress-io:develop Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.clear() isn't really an alias for .type('{selectall}{backspace}')
3 participants