Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hanging due to deep clone on mocha runnable object in server/reporter #14381

Merged
merged 2 commits into from
Jan 4, 2021

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Jan 4, 2021

User facing changelog

Bug Fix: fix issue causing runs with retries enabled to hang

Additional details

we were deep cloning a mocha runnable object, which recursed through runnable.parent and growed exponentially with every test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 4, 2021

Thanks for taking the time to open a PR!

@kuceb kuceb mentioned this pull request Jan 4, 2021
5 tasks
@kuceb kuceb changed the title fix: fix hanging due to deep clone on mocha runnable object in server/reporter fix: hanging due to deep clone on mocha runnable object in server/reporter Jan 4, 2021
@cypress
Copy link

cypress bot commented Jan 4, 2021



Test summary

9179 0 118 3Flakiness 1


Run details

Project cypress
Status Passed
Commit 434e7a8
Started Jan 4, 2021 2:46 PM
Ended Jan 4, 2021 2:57 PM
Duration 11:43 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very snappy! No longer hangs on multiple retries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test retries, when retrying on several failed tests, causes hanging in cypress run
3 participants