-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress should allow fullscreen for AUT #7776
Comments
@jennifer-shehane I've updated the OP. While I was poking around I discovered additional information and have updated title and description accordingly. |
I'm not seeing this second test pass for me with the example provided in Chrome or Firefox. I believe the attribute should be all lowercase, although changing that doesn't make the test pass either. I get what you're explaining now though and this would be a feature request. The MDN docs describe
I'd like to see the passing test you've described. Am I missing something from the example? |
Adds fullscreen button to Visualization items * No cypress tests added since it isn't currently possible to test the fullscreen api in cypress. I'll be keeping an eye on if/when this gets implemented in cypress (cypress-io/cypress#7776) * Minor refactor: move check for whether to show ItemHeaderButtons (pluginIsAvailable) out of ItemHeaderButtons and to Item, so that the logic doesn't get too complex in ItemHeaderButtons (would have been first checking pluginIsAvailable, then checking the fullsreen prop)
# [31.4.0](v31.3.1...v31.4.0) (2021-01-05) ### Features * add fullscreen option to visualization items [DHIS2-9879] ([#1358](#1358)) ([746d7b0](746d7b0)), closes [cypress-io/cypress#7776](cypress-io/cypress#7776)
I ended up using Cypress real events but again I faced one challenge, I couldn't get out of full screen. |
Current behavior:
I have a custom video player that I need to test the various elements of the player controls. Because the containing iframe for the site/app in the test runner does not have the
allowfullscreen='true'
attr. fullscreen features are semi or totally disabled. This is true for all browsers. I'm showing below with Youtube just to show it's not an isolated issue in my environment.Desired behavior:
From what I can tell, simply adding the
allowfullscreen='true'
to the containing iframe (has classaut-iframe
) will allow players (and other sites/apps that need to utilize fullscreen) to use and test features that utilize the fullscreen API.Test code to reproduce
The tests below show the problem/solution in the firefox browser ran locally in the test runner (workaround doesn't work in ci environment for me). The behavior is similar in other browsers, but it was harder to hack fix in a concise way inside a test for demonstration purposes. In Chrome, for example,
fullscreenEnabled
is set to true, making the fullscreen button clickable, but the fullscreen action is still denied. I can mimic the same solution in chrome by manually adding theallowfullscreen
attr. and then reloading the iframe via js in the console.The first test fails because the
fullscreenEnabled
property is false. The second test will pass because I am programmatically adding theallowfullscreen
attr., reloading the iframe, then running the tests.Versions
Cypress 4.8.0, Firefox 76/77 Beta.
Happens in both Mac OS 10.15.5 and Cypress Docker Image via Bitbucket Pipelines: cypress/browsers:node12.18.0-chrome83-ff77
The text was updated successfully, but these errors were encountered: