Skip to content

Commit

Permalink
chore: fix cypress:open and dev scripts
Browse files Browse the repository at this point in the history
  • Loading branch information
astone123 committed Aug 24, 2023
1 parent 53c9c90 commit 6caa15b
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 9 deletions.
2 changes: 1 addition & 1 deletion packages/frontend-shared/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ Our GraphQL frontend client is [urql](https://formidable.com/open-source/urql/)
By convention, we use a prop named `gql` to represent the source of data, so it is common to see things like `props.gql.currentProject`.

### Use of GraphQL by shared components is limited to `src/gql-components`
In the long run, files in the `src/components` directory are intended as the foundation of a design system. As such they may be used in many contexts other than the Cypress App and Launchpad. There are some components that are only intended to be shared between App and Launchpad and make use of GraphQL queries and mutations. These will only work correctly if placed within `src/gql-components` directory, because only that directory is specified in [graphql-codegen.yml](graphql-codegen.yml). This is intended to maintain the separation between genuinely reusable components driven by props and events, and gql-driven components that are tightly bound to the implementation of App and Launchpad.
In the long run, files in the `src/components` directory are intended as the foundation of a design system. As such they may be used in many contexts other than the Cypress App and Launchpad. There are some components that are only intended to be shared between App and Launchpad and make use of GraphQL queries and mutations. These will only work correctly if placed within `src/gql-components` directory, because only that directory is specified in [graphql-codegen.yml](../graphql/graphql-codegen.yml). This is intended to maintain the separation between genuinely reusable components driven by props and events, and gql-driven components that are tightly bound to the implementation of App and Launchpad.

## Generating Fixtures

Expand Down
1 change: 1 addition & 0 deletions packages/graphql/src/utils/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
// created by autobarrel, do not modify directly

export * from './graphqlTypeUtils'
export * from './nexusTypegenUtils'
6 changes: 0 additions & 6 deletions scripts/gulp/gulpfile.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,6 @@ gulp.task('watchForE2E', gulp.series(
*------------------------------------------------------------------------**/

gulp.task('cyRunLaunchpadE2E', gulp.series(
// 1. Build the Cypress App itself
'buildProd',

// Ensure we have no existing cypress processes running
killExistingCypress,

Expand All @@ -156,9 +153,6 @@ gulp.task('cyRunLaunchpadE2E', gulp.series(
))

gulp.task('cyRunAppE2E', gulp.series(
// 1. Build the Cypress App itself
'buildProd',

killExistingCypress,

// 5. Start the REAL Cypress App, which will execute the integration specs.
Expand Down
4 changes: 2 additions & 2 deletions scripts/gulp/tasks/gulpGraphql.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ export async function nexusCodegenWatch () {

export async function graphqlCodegen () {
return spawned('gql-codegen', 'yarn graphql-codegen --config graphql-codegen.yml', {
cwd: monorepoPaths.root,
cwd: monorepoPaths.pkgGraphql,
waitForExit: true,
})
}

export async function graphqlCodegenWatch () {
const spawned = universalSpawn('graphql-codegen', ['--watch', '--config', 'graphql-codegen.yml'], {
cwd: monorepoPaths.root,
cwd: monorepoPaths.pkgGraphql,
})
const dfd = pDefer()
let hasResolved = false
Expand Down

5 comments on commit 6caa15b

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 6caa15b Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.17.5/linux-x64/lerna-optimize-tasks-6caa15bfc912e614759f1ab5e6b0777918d4d1de/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 6caa15b Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.17.5/linux-arm64/lerna-optimize-tasks-6caa15bfc912e614759f1ab5e6b0777918d4d1de/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 6caa15b Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.17.5/darwin-arm64/lerna-optimize-tasks-6caa15bfc912e614759f1ab5e6b0777918d4d1de/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 6caa15b Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.17.5/darwin-x64/lerna-optimize-tasks-6caa15bfc912e614759f1ab5e6b0777918d4d1de/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 6caa15b Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.17.5/win32-x64/lerna-optimize-tasks-6caa15bfc912e614759f1ab5e6b0777918d4d1de/cypress.tgz

Please sign in to comment.