This repository has been archived by the owner on Mar 5, 2022. It is now read-only.
fix: use display name of the component #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 22, 2019 15:34
* Adding tests for React.memo * Adding tests for React.forwardRef * Adding basic hook tests
* Fixing bad .type property in get where the selector is a function * Ensuring all specs pass * Adding stub for hooks spec for the time being...
|
Looks like travis has some missing dependencies for cypress. Uploading the test report |
bahmutov
reviewed
Jun 5, 2019
|
|
||
| /* eslint-env mocha */ | ||
| describe('CounterWithHooks component', function () { | ||
| it.skip('works', function () { |
There was a problem hiding this comment.
can I ask why this test is skipped - is it not working yet?
There was a problem hiding this comment.
Related to #51 I wasn't able to get it working. Leaving it there as a stub for now
|
Super, merging this now, thank you @atomicpages - if you plan any more contributions, let me know, I could just add you as a collaborator to this repo |
|
Sure! I can tackle a few more issues 👍 |
Merged
dmtrKovalenko
pushed a commit
to cypress-io/cypress
that referenced
this pull request
Oct 1, 2020
…-test#92) * Fixing cypress-io/cypress-react-unit-test#91 * Adding tests for React.memo * Adding tests for React.forwardRef * Adding basic hook tests * Fixing some issues * Fixing bad .type property in get where the selector is a function * Ensuring all specs pass * Adding stub for hooks spec for the time being...
dmtrKovalenko
pushed a commit
to cypress-io/cypress
that referenced
this pull request
Oct 1, 2020
cypress-io/cypress-react-unit-test#92 broke the alias functionality. If a jsx.type exists, the alias will be ignored. This restores the alias functionality such that a supplied alias will override the jsx.type.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React.memoReact.forwardRefgetDisplayNamefunction used by react-devtools