Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document domain option for cookie commands #4824

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

chrisbreiding
Copy link
Contributor

@vercel
Copy link

vercel bot commented Nov 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cypress-documentation ✅ Ready (Inspect) Visit Preview Nov 2, 2022 at 1:48PM (UTC)

@@ -39,6 +39,7 @@ Pass in an options object to change the default behavior of `cy.clearCookie()`.

| Option | Default | Description |
| --------- | -------------------------------------------------------------- | ---------------------------------------------------------------------------------------- |
| `domain` | Superdomain of the current URL | Clears the cookie from the specified domain |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we link the user to what a superdomain is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe once there's one to link to as part of #4809? 😬

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be ideal. Gonna see if I can look into that soon so we at least have a reference

@AtofStryker AtofStryker self-requested a review November 3, 2022 16:24
@chrisbreiding chrisbreiding changed the base branch from master to release-11.0.0 November 7, 2022 17:10
@chrisbreiding chrisbreiding merged commit 61407e3 into release-11.0.0 Nov 8, 2022
@chrisbreiding chrisbreiding deleted the issue-24264-cookie-domain branch November 8, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants