Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs continuous integration using Circleci #412

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Improve docs continuous integration using Circleci #412

merged 1 commit into from
Feb 12, 2018

Conversation

saadaouad
Copy link
Contributor

@saadaouad saadaouad commented Feb 9, 2018

What is new on this PR?

Since i get this error in Circleci


+
TEST
Spin up Environment00:01
Checkout code00:00
npm install02:17
$(npm bin)/cypress run --record00:09
Exit code: 1
#!/bin/bash -eo pipefail
$(npm bin)/cypress run --record
npm info it worked if it ends with ok
npm info using npm@3.10.10
npm info using node@v6.11.1
npm info ok 
It looks like this is your first time using Cypress: 1.4.2

[01:25:47]  Verifying Cypress can run /var/www/node_modules/cypress/dist/Cypress [started]
[01:25:49]  Verifying Cypress can run /var/www/node_modules/cypress/dist/Cypress [completed]

Opening Cypress...
You passed the --record flag but did not provide us your Record Key.

You can pass us your Record Key like this:

  cypress run --record --key <record_key>

You can also set the key as an environment variable with the name CYPRESS_RECORD_KEY.

https://on.cypress.io/how-do-i-record-runs
Exited with code 1

I think it's better to add --key <record_key> in the docs

@CLAassistant
Copy link

CLAassistant commented Feb 9, 2018

CLA assistant check
All committers have signed the CLA.

@saadaouad
Copy link
Contributor Author

FYI @jennifer-shehane

@bahmutov bahmutov merged commit dabc086 into cypress-io:develop Feb 12, 2018
@bahmutov
Copy link
Contributor

👍 thanks @saadaouad

@saadaouad
Copy link
Contributor Author

saadaouad commented Feb 12, 2018

Sure @bahmutov

@saadaouad saadaouad deleted the update-circleci-docs branch February 12, 2018 19:13
jennifer-shehane added a commit that referenced this pull request Feb 13, 2018
Improve docs continuous integration using circleci (#412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants