-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: linux/arm64
multi-platform support
#700
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
10 tasks
lmiller1990
reviewed
Jul 11, 2022
rockhold
reviewed
Jul 12, 2022
mjhenkes
reviewed
Jul 12, 2022
mjhenkes
approved these changes
Jul 12, 2022
admah
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Great work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #431
Closes cypress-io/cypress#22167
This PR introduces beta support for
linux/arm64
images, mainly to enable M1 users to run Cypress docker images locally.The only known limitation is that none of Chrome, Firefox, or Edge officially support
linux-arm64
yet - so this means none of thebrowsers
orincluded
images will have browsers onlinux/arm64
. Users will have to use--browser electron
or obtain their ownarm64
browser binaries.As
arm64
binaries become available, they will be added to these images. See #695 for details.For now, users will see this warning on arm64:
This PR also:
docker buildx
in CI@admah we still need to make a decision on how far back we want to go with updating older images to have
linux/arm64
builds - right now, I'm thinking we'll just do the latestincluded
image, and thebrowsers
andbase
images upon which that relies.Pre-merge:
Post-merge: