Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: linux/arm64 multi-platform support #700

Merged
merged 71 commits into from
Jul 14, 2022
Merged

feat: linux/arm64 multi-platform support #700

merged 71 commits into from
Jul 14, 2022

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jul 11, 2022

Closes #431
Closes cypress-io/cypress#22167

This PR introduces beta support for linux/arm64 images, mainly to enable M1 users to run Cypress docker images locally.

The only known limitation is that none of Chrome, Firefox, or Edge officially support linux-arm64 yet - so this means none of the browsers or included images will have browsers on linux/arm64. Users will have to use --browser electron or obtain their own arm64 browser binaries.

As arm64 binaries become available, they will be added to these images. See #695 for details.

For now, users will see this warning on arm64:
image

This PR also:

  • Moves our AWS ECR image generation to Circle, dropping the need for AWS BuildSpec
  • Switches to docker buildx in CI
  • Adds snapshot tests for "generate-config" (1418 lines of this diff are snapshots)

@admah we still need to make a decision on how far back we want to go with updating older images to have linux/arm64 builds - right now, I'm thinking we'll just do the latest included image, and the browsers and base images upon which that relies.

Pre-merge:

  • Remove Circle environment variables, add Docker Hub and AWS ECR creds to Circle Context

Post-merge:

  • Release linux/arm64 builds for select images on ECR and Hub

@flotwig
Copy link
Contributor Author

flotwig commented Jul 11, 2022

will this also close out #694? Did you remove all references to cly?

@admah I just removed the final mention 👍 This PR can replace #694 now

@flotwig flotwig requested a review from rockhold July 11, 2022 20:03
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@admah admah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple M1/Silicon/arm64 Epic Impossible to install with docker for mac M1 (linux/arm64/v8)
6 participants