-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a warn when user closes tab or browser with unsaved changes to … #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josaphatim
force-pushed
the
warn-for-unsaved-changes
branch
from
February 14, 2023 07:59
6acd603
to
c5d110f
Compare
henrique-borba
approved these changes
Jun 19, 2023
kroky
reviewed
Jun 23, 2023
kroky
reviewed
Jun 23, 2023
josaphatim
force-pushed
the
warn-for-unsaved-changes
branch
from
December 21, 2023 07:27
c5d110f
to
6811cfc
Compare
marclaporte
reviewed
Dec 21, 2023
third_party/jquery.are-you-sure.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great to re-use code but we need to know the source, license, etc.
josaphatim
force-pushed
the
warn-for-unsaved-changes
branch
2 times, most recently
from
December 22, 2023 05:16
49a4fcf
to
afd2eea
Compare
@kroky I have made changes can you check please ? |
kroky
reviewed
Dec 22, 2023
josaphatim
force-pushed
the
warn-for-unsaved-changes
branch
from
December 22, 2023 08:40
afd2eea
to
f5c2b6b
Compare
marclaporte
reviewed
Dec 22, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone closes browser, or tab and has unsaved changes to settings this attempts to warn him.
Fixes: - #523