Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a warn when user closes tab or browser with unsaved changes to … #669

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

josaphatim
Copy link
Member

If someone closes browser, or tab and has unsaved changes to settings this attempts to warn him.

Fixes: - #523

@josaphatim josaphatim force-pushed the warn-for-unsaved-changes branch from 6acd603 to c5d110f Compare February 14, 2023 07:59
modules/core/site.js Outdated Show resolved Hide resolved
modules/core/site.js Outdated Show resolved Hide resolved
@josaphatim josaphatim force-pushed the warn-for-unsaved-changes branch from c5d110f to 6811cfc Compare December 21, 2023 07:27
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to re-use code but we need to know the source, license, etc.

@josaphatim josaphatim force-pushed the warn-for-unsaved-changes branch 2 times, most recently from 49a4fcf to afd2eea Compare December 22, 2023 05:16
@josaphatim
Copy link
Member Author

@kroky I have made changes can you check please ?

modules/core/site.js Outdated Show resolved Hide resolved
@josaphatim josaphatim force-pushed the warn-for-unsaved-changes branch from afd2eea to f5c2b6b Compare December 22, 2023 08:40
@kroky kroky merged commit a7ca9be into cypht-org:master Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants