New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Better workflow for adding contacts from emails #666

Merged

kroky merged 25 commits into cypht-org:master from henochit:feat-add-contact

Oct 18, 2023

Member

henochit commented Jan 17, 2023 •

edited by marclaporte

Loading

Pullrequest

When I click on an email, offers to user to add to contacts.

If a contact already exists with that email, it should offer a link (or perhaps many) to review the rest of the contact information.
If no contact exists with that email, it should offer me to add it as a contact.

related to:

https://avan.tech/item40524

Issues

None

Checklist

None

How2Test

Open an email
Click the sender. If the sender is not a local contact, they should offer a button to add the sender as a contact. If the contact exists, you will see the rest of the coordinates.

Todo

None

kroky reviewed

View reviewed changes

modules/contacts/hm-contacts.php Outdated Show resolved Hide resolved

kroky reviewed

View reviewed changes

modules/contacts/hm-contacts.php Show resolved Hide resolved

kroky reviewed

View reviewed changes

modules/imap/site.js Outdated Show resolved Hide resolved

kroky reviewed

View reviewed changes

scripts/hm3.ini Outdated Show resolved Hide resolved

kroky reviewed

View reviewed changes

scripts/hm3.rc Outdated Show resolved Hide resolved

Member

kroky commented Aug 10, 2023

@henochit , please let me know when this is ready for review.

Member Author

henochit commented Aug 10, 2023

@kroky ready to be reviewed.

kroky reviewed

View reviewed changes

modules/contacts/site.js Show resolved Hide resolved

kroky reviewed

View reviewed changes

modules/contacts/site.js Outdated Show resolved Hide resolved

Member

kroky commented Aug 14, 2023

@henochit please also rebase master as there are conflicts to resolve in imap/site.css

henochit and others added 20 commits

September 25, 2023 20:36


          Fix: .gitignore hm3 files

be5749a


          Fix: conflict

ffc1898


          Feat: add dropdown arrow image

452d558


          Fix: conflict

75c8e24


          Refactor (add contact function): split function by adding add contact…

1b8f4a5

… from popup


          Fix: conflicts

8db1d68


          Fix: refactor get contact function

e61c3bb


          lint: remove space

62dcf96


          Fix: git ignore scripts/hm3.rc

8d10698


          Fix: git ignore scripts/hm3.ini

637f0f3


          Fix: conflicts

64d1fc2


          Fix: conflicts

8187bad


          Ref: Set simple UI as default

5a2d883


          Fix: remove imap_per_page_setting from setup.php

45b7c9e


          Ref: delete untracked files

f2dd6a5


          Feat: add dropdown on contact bubbles

ddf3045


          Ref: search contact api

7d5eecd


          Feat: implement edit contact dropdown

cdb9880


          Fix: dropdown actions

c2db4a4


          Added a way to support sieve extensions

88ff720

josaphatim and others added 2 commits

September 25, 2023 20:53


          Added a way to check sieve server capabilities

feaf52b


          Fix: remove duplicated function 'add_contact_from_popup'

39da55f

henochit force-pushed the feat-add-contact branch from dd2a4a9 to 39da55f Compare

September 25, 2023 19:54


          Fix: conflicts

e9de4fa

kroky reviewed

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

henochit added 2 commits

October 17, 2023 13:00


          Ref: clean session storage on save contact

6140ef5


          Fix: remove wrong path in .gitignore

2a2a9e0

Member Author

henochit commented Oct 17, 2023

@kroky, ready to be merged.

kroky merged commit a528575 into cypht-org:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet