fix(other): save settings displaying wrong message #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IrAlfred
force-pushed
the
fix-save-settings-displaying-wrong-msg
branch
from
d863cb9 to
136b0a5
Compare
kroky
reviewed
Feb 13, 2025
kroky
reviewed
Feb 13, 2025
IrAlfred
force-pushed
the
fix-save-settings-displaying-wrong-msg
branch
from
136b0a5 to
1f754d3
Compare
IrAlfred
force-pushed
the
fix-save-settings-displaying-wrong-msg
branch
from
1f754d3 to
9eae5d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where the application incorrectly displays a "Settings saved" message even when the save operation failed due to permission or folder-related issues. The changes ensure that the application only displays success messages when the save operation is confirmed to be successful