Missing fields fix #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Thanks for the bug report and even more for taking the time to create a pull request to fix it. Pull request looks fine, bar minor differences in how I would format the code versus you but nothing worth grouching over. Looks like I'll need to add a CONTRIBUTORS.md file :) I can merge this in now, but I won't have time to update the nuget package until the weekend, hope that is fine. Regards; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for the great library, which is very useful for my game engine.
However when I tried to load some FNT with it, it threw the FormatException.
It seems that it doesnt check whether a field exist or not (in my case missing field was 'outline'), but tries to process it's value with Int.Parse. I've made a fix for that issue.
Thanks.