Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support returning in rows_*.tbl_dbi() #607

Merged
merged 21 commits into from
Aug 31, 2021
Merged

Support returning in rows_*.tbl_dbi() #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
40f6580
Support `returning` in `rows_insert.tbl_dbi()`
mgirlich Aug 17, 2021
a13f244
Refactor
mgirlich Aug 18, 2021
1bea8cf
Support `returning` in `rows_update()` and `rows_delete()`
mgirlich Aug 18, 2021
2a2348b
Document() + tests
mgirlich Aug 18, 2021
c3aa443
Add `returning` in `rows_*()` instead of `sql_rows_*()`
mgirlich Aug 19, 2021
788eeaf
Add `sql_returning()`
mgirlich Aug 19, 2021
bdfd46e
Merge `returning_clause()` into `sql_returning()`
mgirlich Aug 19, 2021
b6601ea
Add `has_returned_rows()` + mark experimental
mgirlich Aug 20, 2021
daebf80
Use dev RSQLite
mgirlich Aug 20, 2021
fceb0b5
Require RSQLite 2.2.8
mgirlich Aug 23, 2021
98c1c9c
Add `has_returned_rows()` to pkgdown
mgirlich Aug 27, 2021
7bb0d74
Check that `returning` needs `in_place` true
mgirlich Aug 27, 2021
0643a53
Merge branch 'main' into rows-insert-returning
krlmlr Aug 31, 2021
ca1631c
Tweak documentation
krlmlr Aug 31, 2021
2a2f602
Tweak tests
krlmlr Aug 31, 2021
eff86b3
Less eager suppression
krlmlr Aug 31, 2021
a97db6d
Quote
krlmlr Aug 31, 2021
8e8b44d
data -> target
krlmlr Aug 31, 2021
33e1040
Need sql_output_cols() for SQL Server
krlmlr Aug 31, 2021
aff76c8
sql_returning() -> sql_returning_cols()
krlmlr Aug 31, 2021
6381d55
Indent
krlmlr Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Suggests:
RMariaDB (>= 1.0.10),
rmarkdown,
RPostgres,
RSQLite,
RSQLite (>= 2.2.8),
testthat (>= 3.0.2),
tidyverse,
withr
Expand Down
9 changes: 9 additions & 0 deletions NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,11 @@ S3method(separate,dm)
S3method(separate,zoomed_dm)
S3method(slice,dm)
S3method(slice,zoomed_dm)
S3method(sql_output_cols,"tbl_Microsoft SQL Server")
S3method(sql_output_cols,default)
S3method(sql_returning_cols,"tbl_Microsoft SQL Server")
S3method(sql_returning_cols,tbl_SQLiteConnection)
S3method(sql_returning_cols,tbl_dbi)
S3method(sql_rows_delete,tbl_sql)
S3method(sql_rows_insert,tbl_sql)
S3method(sql_rows_truncate,tbl_SQLiteConnection)
Expand Down Expand Up @@ -258,7 +263,9 @@ export(enum_pk_candidates)
export(examine_cardinality)
export(filter)
export(full_join)
export(get_returned_rows)
export(group_by)
export(has_returned_rows)
export(inner_join)
export(is_dm)
export(left_join)
Expand All @@ -278,6 +285,8 @@ export(rows_upsert)
export(select)
export(semi_join)
export(separate)
export(sql_output_cols)
export(sql_returning_cols)
export(sql_rows_delete)
export(sql_rows_insert)
export(sql_rows_truncate)
Expand Down
Loading