Execute GitHub action on pull requests too and fix coverage #324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change with no associated Issue.
Noticed that after marking a PR as ready for review it was not showing that the GItHub action had run successfully. Then found a similar issue (that repository has a lot of useful things for actions), and turns out I also did not include the
on: [pull_request]
, onlyon: [push]
.EDIT: added an extra commit to fix the coverage reports. Will have to add a secret token to the repo settings too, as documented in the Codecov github action docs: https://github.com/codecov/codecov-action
One review should to 👍
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.