Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute GitHub action on pull requests too and fix coverage #324

Merged
merged 2 commits into from
Dec 9, 2019

Conversation

kinow
Copy link
Member

@kinow kinow commented Dec 4, 2019

This is a small change with no associated Issue.

Noticed that after marking a PR as ready for review it was not showing that the GItHub action had run successfully. Then found a similar issue (that repository has a lot of useful things for actions), and turns out I also did not include the on: [pull_request], only on: [push].

EDIT: added an extra commit to fix the coverage reports. Will have to add a secret token to the repo settings too, as documented in the Codecov github action docs: https://github.com/codecov/codecov-action

One review should to 👍

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (why? build only).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.

@kinow kinow added this to the 0.2 milestone Dec 4, 2019
@kinow kinow self-assigned this Dec 4, 2019
@kinow
Copy link
Member Author

kinow commented Dec 4, 2019

Best way to review is just read the one-line change, and confirm that in this PR the GitHub action appeared as a "check" (same way that it used to appear for Travis/Codacy/etc).

image

Should be visible somewhere 👇

@kinow kinow mentioned this pull request Dec 8, 2019
6 tasks
@kinow kinow changed the title Execute GitHub action on pull requests too Execute GitHub action on pull requests too and fix coverage Dec 9, 2019
@hjoliver hjoliver merged commit a924c1b into cylc:master Dec 9, 2019
@kinow kinow mentioned this pull request Dec 10, 2019
@kinow kinow deleted the action-on-pr branch March 19, 2020 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants