actions: add cylc-uiserver to build env #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
added
the
infrastructure
oliver-sanders
commented
Nov 12, 2021
wxtim
reviewed
Nov 12, 2021
| run: | | ||
| # NOTE: Install with [all] so we can import plugins which may | ||
| # have extra dependencies. | ||
| pip install \ | ||
| "cylc-flow[all] @ git+https://github.com/cylc/cylc-flow@${cylc_flow}" \ | ||
| "metomi-rose[all] @ git+https://github.com/metomi/rose@${meto_rose}" \ | ||
| "cylc-rose[all] @ git+https://github.com/cylc/cylc-rose@${cylc_rose}" | ||
| "cylc-rose[all] @ git+https://github.com/cylc/cylc-rose@${cylc_rose}" \ |
There was a problem hiding this comment.
I tried to test this, and get a dependency error:
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/user_guide/#fixing-conflicting-dependencies
cylc-flow[all] 8.0rc1.dev0 depends on cylc-flow 8.0rc1.dev0 (from git+https://github.com/cylc/cylc-flow@master)
cylc-rose[all] 0.3.0 depends on cylc-flow==8.0b3.*
would it be reasonable to loosen the cylc-rose dependency at https://github.com/cylc/cylc-rose/blob/c9eef34a118913a0137ac08d5b4330ac38454d49/setup.py#L31 to something like 8.0.*?
There was a problem hiding this comment.
No, this version is correct.
wxtim
requested changes
Nov 12, 2021
|
This will work after cylc/cylc-rose#94 |
94 is merged; this is still failing. |
datamel
approved these changes
Nov 15, 2021
Just needed to be re-triggered. |
This was referenced Nov 15, 2021
Merged
wxtim
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cylc-uiserver to the build/test environment.
Required for #300