refactor: use reject not return false

- Use reject to catch exception better than return false
cylab-tw · Mar 16, 2023 · cf2bbeb · cf2bbeb
1 parent 91e3d84
commit cf2bbeb
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/models/dcmtk/index.js b/models/dcmtk/index.js
@@ -94,7 +94,7 @@ function dcm2json(filename) {
 const dcm2jsonC = require('dicom-to-json');
 const dcm2jsonV8 = {
     exec : function (dcmfile) {
-        return new Promise((resolve) => {
+        return new Promise((resolve, reject) => {
             try {
                 dcm2jsonC.dcm2json(dcmfile , function (data) {
                     data = data.replace(/,\\u0000/g, '');
@@ -103,8 +103,7 @@ const dcm2jsonV8 = {
                     return resolve(obj);
                 });
             } catch (e) {
-                console.error(e);
-                return resolve(false);
+                return reject(new Error(e));
             }
         });
     } ,