fix: os.userInfo() might throw SystemError if homedir isn't available #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyjake
force-pushed
the
fix-userinfo-systemerror
branch
from
e6b9ca1
to
a3b9831
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
==========================================
- Coverage 97.16% 96.88% -0.29%
==========================================
Files 3 3
Lines 318 321 +3
Branches 87 88 +1
==========================================
+ Hits 309 311 +2
Misses 4 4
- Partials 5 6 +1 ☔ View full report in Codecov by Sentry. |
cyjake
force-pushed
the
fix-userinfo-systemerror
branch
5 times, most recently
from
2dbdb93
to
ecde706
Compare
cyjake
force-pushed
the
fix-userinfo-systemerror
branch
from
ecde706
to
7ec2a55
Compare
| try { | ||
| userInfo = os.userInfo() | ||
| } catch { | ||
| // os.userInfo() throws a SystemError if a user has no username or homedir. |
There was a problem hiding this comment.
FYI: this comment isn't necessarily precise
namely this can happen as well if the user is a "remote" user (e.g. LDAP scenario)
There was a problem hiding this comment.
It was copied from the documentation of os.userInfo() 😂 I guess if the user is "remote", homedir won't be available as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #77