Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render unsegregated cycle track as light blue #652

Merged
merged 10 commits into from
Aug 1, 2023

Conversation

kaneap
Copy link
Contributor

@kaneap kaneap commented Jul 6, 2023

Fixes #640

Description

This PR sets the color of cycleway(:left/:right/:both)=track to light blue (same color as bicycle=designated on unsegregated highway=path) when cycleway(:left/:right/:both):segregated=no.
The rules xml file generated is slightly larger after this change: From 7MB to 7.4MB

Examples

Example 1:

A two-way shared cycle and foot path on one side of the road.
Location: https://www.openstreetmap.org/way/50741273
Before:
shared_path_before
After:
shared_path_after

Example 2:

A one-way shared cycle and foot path on one side of the road.
Location: https://www.openstreetmap.org/way/654562266
Before:
shared_2_before
After:
shared_2_after

Example 3:

One way shared cycle and foot paths on both sides of the road.
Location: https://www.openstreetmap.org/way/515092494
Before:
shared_3_before
After:
shared_3_after

@Phyks
Copy link
Member

Phyks commented Jul 11, 2023

Hi!

Thanks for the PR! I did not do a full review yet, but looks good to me. I'll have a deeper look and merge ASAP.

@Phyks Phyks merged commit c4e8611 into cyclosm:master Aug 1, 2023
1 check passed
@Phyks
Copy link
Member

Phyks commented Aug 1, 2023

Merged, thanks! It will be available in the next deployed version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: render cycleway:[left:|right:|both:]segregated:no similar to shared bicycle/foot path
2 participants