Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix underground bicycle parkings masking buildings. Fix #505. #507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Phyks
Copy link
Member

@Phyks Phyks commented Jan 25, 2021

No description provided.

@Florimondable
Copy link
Member

Well, I'd like to render also underground bicycle parking, no ?

@Phyks
Copy link
Member Author

Phyks commented Jan 26, 2021

It's still rendered, but only with an icon, not with the whole surface render.

@Florimondable
Copy link
Member

Ok, but I think it's usefull to know what is the shape of the bicycle parking to know where is the entrance. An icon lost in nowhere doesn't help much.

May be we should render amenities_poly under road layers ? With building layer ?

@Phyks
Copy link
Member Author

Phyks commented Jan 27, 2021

We cannot move the whole amenities-poly layer since we want the icons to be always on top.

We might move the surface rendering in the landuse layer? https://github.com/cyclosm/cyclosm-cartocss-style/blob/master/project.mml#L137-L165

This would not work for a surface bicycle parking on top of the roof of a building though.

@Florimondable
Copy link
Member

Florimondable commented Jan 28, 2021

We cannot move the whole amenities-poly layer since we want the icons to be always on top.

Yes, we need to keep this layer for icon rendering, but area can be moved.

We might move the surface rendering in the landuse layer? https://github.com/cyclosm/cyclosm-cartocss-style/blob/master/project.mml#L137-L165

This would not work for a surface bicycle parking on top of the roof of a building though.

Yeah, I think we need to think at "how to render bicycle parking area as an indoor, or building like amenities", so may be we can use the "buildings" layer ?
Roads would be rendered over, and we could layers things over/under the bicycle parking areas.

@Phyks Phyks linked an issue Mar 14, 2021 that may be closed by this pull request
@Phyks Phyks changed the title Fix udnerground bicycle parkings masking buildings. Fix #505. Fix underground bicycle parkings masking buildings. Fix #505. May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Underground parking amenities are rendered on top of ways
2 participants