Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better segregated rendering #450

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

brainwad
Copy link
Contributor

@brainwad brainwad commented Nov 13, 2020

This PR does two things:

First, it changes the colour of the pedestrian side-way, rendered at z17+ when segregated=yes, away from green. Green would have made sense before footways were shifted from green to brown, but now it doesn't so much - if two separate lines are rendered, the non-bicycle one should be rendered as non-bicycle ways are normally: brown. The colour of a bridleway is used if the way supports horse-riders (including paths that don't exclude them explicitly), otherwise the colour of a footway:

image

(there are two in the image, on either side of the synagogue: the top one is a path, so uses bridleway colouring; the bottom is a footway and so uses footway colouring)

Secondly, and dependent of the first change, it adds support for rendering the side-way for segregated paths that don't have bicycle=designated (designated is only tagged in some countries when a path legally requires usage; in these countries it doesn't imply anything about the quality of the path for cyclists, and a bicycle=yes segregated=yes path could be equal or higher-standard). This would have been confusing before the colour change, because it would have just rendered a path-coloured side-way next to the path-coloured main way, which would have just looked like a fat path, not two side-by-side ways. Now with the brown colour it works:

image

Currently segregated cycleways are rendered as a cycleway + a (green) path, but as the green is meant to imply cyclability, and the non-cycle portion is not cyclable, it makes sense to colour it as a bridleway or footway depending on whether or not horse traffic is allowed, respectively.
@brainwad
Copy link
Contributor Author

After taking the screenshots, I can barely tell the difference between bridleway and footway shading. Also, while path's default horse is yes, in practice most paths tagged with segregated and bicycle do not ever see horses. Should I remove the horse support and just always use footway colour? Should we do that for all bridleways?

@brainwad brainwad marked this pull request as ready for review November 14, 2020 09:13
@Florimondable
Copy link
Member

Hm, I think we should keep thing simple :
If bicycle=designated AND seggregated=yes -> cycleway + path rendered next to it
else path rendering.
Other condition are not related to cycling.

Brown is the color for pedestrian, red brown for horseman.

@brainwad
Copy link
Contributor Author

brainwad commented Nov 18, 2020

But like I mentioned, bicycle=yes segregated=yes is a thing. designated in many countries means that the law requires you to use the path, not that it's of a certain quality. A path with bicycle=yes can be equal or better quality than a path with bicycle=designated. And since non-designated paths are green, without the change to brown for the side-path, it will be illegible.

Some examples of non-designated segregated paths that I have tagged recently, on Mapillary:
https://www.mapillary.com/map/im/cAGs_AO9jDMCWBK5yWfAOw
https://www.mapillary.com/map/im/EBqLADoy4cvkpDyNdIaKpQ

@brainwad
Copy link
Contributor Author

Also: I don't really get why the map has both brown and red-brown for foot/horse... This is a cycle map, surely one shade of brown for both is fine?

@Florimondable
Copy link
Member

Some examples of non-designated segregated paths that I have tagged recently, on Mapillary:
https://www.mapillary.com/map/im/cAGs_AO9jDMCWBK5yWfAOw
https://www.mapillary.com/map/im/EBqLADoy4cvkpDyNdIaKpQ
Those path are designated for cyclist, the bicycle logo on the ground.

Briddleway rendered differently than footway, because most of the time the briddleway I know are made of sand, which is horrible for bicycle, so even without knowing its surface its good to have a warning about it.

@brainwad
Copy link
Contributor Author

brainwad commented Nov 18, 2020 via email

@Florimondable
Copy link
Member

Designated value doesn't mean the way is compulsory.
If so the value use_sidepath can be used https://wiki.openstreetmap.org/wiki/Tag:bicycle%3Duse_sidepath.

@brainwad
Copy link
Contributor Author

brainwad commented Nov 18, 2020 via email

@Florimondable
Copy link
Member

I can't find in the pages that designated should be use when it's compulsory.

@brainwad
Copy link
Contributor Author

brainwad commented Nov 18, 2020 via email

@VladimirMorozov
Copy link

Some examples of non-designated segregated paths that I have tagged recently, on Mapillary:
https://www.mapillary.com/map/im/cAGs_AO9jDMCWBK5yWfAOw
https://www.mapillary.com/map/im/EBqLADoy4cvkpDyNdIaKpQ

Hello, just want to be sure. These yellow road markings don't hold the same meaning as the round blue signs, correct? In my country similar road markings would have the same meaning as signs, that's why I'm asking.

@brainwad
Copy link
Contributor Author

brainwad commented Jul 7, 2021

@VladimirMorozov without the blue signs they are just advisory - you may use them, but don't have to. With the signs, they are compulsory - you aren't allowed to ride on the road anymore, but must use the path. It also has some consequences for electric scooters/skateboards, fast electric bikes ("s-pedelecs") & light mopeds ("mofas"): the blue signs allow them to use their motor while without it they can't.

@kaneap
Copy link
Contributor

kaneap commented Sep 4, 2022

I believe that any path with segregated=yes should be rendered the same regardless of whether it is bicycle=yes or bicycle=designated (dark blue= exclusive cycle path, which is implied by segregated=yes, regardless of whether you must use it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants