Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Postgres array type detection #203

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Add Postgres array type detection #203

merged 7 commits into from
Oct 22, 2024

Conversation

mastir
Copy link
Contributor

@mastir mastir commented May 23, 2024

🔍 What was changed

detect internal array types as string[], integer[] and float[] insteed of ARRAY

🤔 Why?

There is no way to detect actual column type for arrays. In ORM any of array columns treated as unknown type with string typecast, but with custom typecast this columns can be detected and used properly

detect internal array types as string[], integer[], float[] insteed of ARRAY
@mastir mastir requested review from a team as code owners May 23, 2024 12:09
@roxblnfk
Copy link
Member

Hi.
I've updated the thread so the CI tests are passing.
But for any code change we need additional tests.

@roxblnfk roxblnfk added the type: feature New feature. label Jun 10, 2024
@mastir
Copy link
Contributor Author

mastir commented Jun 16, 2024

Thank you @roxblnfk,
I`ve added new test case and few more type detections to cover all of the postgres basic types

@mastir mastir force-pushed the patch-1 branch 2 times, most recently from 5611c9d to 401afd8 Compare June 16, 2024 23:28
@roxblnfk roxblnfk requested a review from a team as a code owner October 22, 2024 14:49
@roxblnfk roxblnfk changed the title feat: postgres array type detection Add Postgres array type detection Oct 22, 2024
@roxblnfk roxblnfk merged commit 40f4115 into cycle:2.x Oct 22, 2024
32 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants