Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[!] add support for IPv6 #225

Merged
merged 3 commits into from
May 10, 2024
Merged

[!] add support for IPv6 #225

merged 3 commits into from
May 10, 2024

Conversation

zhongyibill
Copy link
Contributor

fix issue #224

pashagolub
pashagolub reviewed May 9, 2024
View reviewed changes
main.go Outdated Show resolved Hide resolved
@zhongyibill @pashagolub
Update main.go
344aa43 
Co-authored-by: Pavlo Golub <pavlo.golub@gmail.com>
@pashagolub pashagolub self-assigned this May 10, 2024
pashagolub
pashagolub requested changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@pashagolub pashagolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix syntax error

main.go Outdated Show resolved Hide resolved
@pashagolub
Copy link
Collaborator

Thanks for your help! Just a friendly advice for a next time you create a pull request please:

  1. Create a separate branch in your cloned repo (do not use master)
  2. Allow maintainers to push additional commits to your branch and pull request

This way I may fix or apply some changes directly.

@pashagolub pashagolub changed the title support IPV6 [!] add support for IPv6 May 10, 2024
@pashagolub pashagolub merged commit 4869dca into cybertec-postgresql:master May 10, 2024
4 checks passed
@pashagolub pashagolub mentioned this pull request May 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pashagolub pashagolub pashagolub approved these changes

Assignees

@pashagolub pashagolub

Labels
enhancement
Projects
vip-manager
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhongyibill @pashagolub