Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[*] port behaviour tests to etcd v3 API, closes #126 #127

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

mbanck
Copy link
Contributor

@mbanck mbanck commented Jan 3, 2023

This replaces curl/jq calls with etcdctl, as the V3 API is much more difficult to use via curl.

Fixes #126.

This replaces curl/jq calls with etcdctl, as the V3 API is much more difficult
to use via curl.
@mbanck
Copy link
Contributor Author

mbanck commented Jan 3, 2023

So, not sure how to proceed here - I'm using a locally running etcd for the Debian autopkgtests, and haven't tested the podman stuff. As test/behaviou_test.sh has everything commented out, I proceeded to do so for the other two tests as well, but probably something self-consisten (and/or usable with Github actions or so?) is needed here.

When you use a local etcd you can use the better check for the vip from the bottom of behaviour_test.sh in the other two tests as well instead of grepping, I could add that.

@pashagolub pashagolub changed the title Port behaviour tests to V3 API. [*] port behaviour tests to etcd v3 API, closes Jan 3, 2023
@pashagolub pashagolub changed the title [*] port behaviour tests to etcd v3 API, closes [*] port behaviour tests to etcd v3 API, closes #126 Jan 3, 2023
@pashagolub pashagolub requested a review from markwort January 6, 2023 13:49
@pashagolub pashagolub added the bug label Jan 6, 2023
Copy link
Collaborator

@pashagolub pashagolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pashagolub pashagolub self-assigned this Jan 16, 2023
@pashagolub pashagolub merged commit 26d595f into cybertec-postgresql:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

behaviour_test.sh needs porting to etcdv3
3 participants