Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an autoremember timer #331

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add an autoremember timer #331

wants to merge 4 commits into from

Conversation

cxw42
Copy link
Owner

@cxw42 cxw42 commented Nov 24, 2024

Add a setting that, if a positive integer I, will cause all windows to be autoremembered every I minutes.

Fixes #316.

@cxw42 cxw42 self-assigned this Nov 24, 2024
@cxw42 cxw42 mentioned this pull request Nov 24, 2024
Open
@andr222
Copy link

andr222 commented Feb 2, 2025

Good news.
Not yet
How do I try it ?

@cxw42
Copy link
Owner Author

cxw42 commented Feb 16, 2025

@andr222 sorry for the delay in responding! CONTRIBUTING.md has instructions (tested on Ubuntu 20.04).

  1. Do the "Getting started" section and step 1 of the "Developing" section.
  2. Instead of "Developing" step 2, git switch issue316-autosave-timer
  3. Do steps 3--5 of the "Developing" section

This will give you a separate TabFern installation in which you can test out the feature. It is totally separate from your Chrome Web Store TF installation, and will show up with an orange icon instead of a green icon.

cxw42 added 2 commits February 16, 2025 15:21
@cxw42
setting-accessors: add remove() to remove a setting
f9f8edb
@cxw42
Support integer-valued settings
1c8bba2 
- Add getIntSetting() method
- Export default validators from setting-definitions
- Add tests of setting-definitions and setting-accessors
@cxw42 cxw42 force-pushed the issue316-autosave-timer branch from e4f43dd to c638b55 Compare February 16, 2025 20:43
@cxw42
Copy link
Owner Author

cxw42 commented Feb 16, 2025

Force-push changes:

  • Rebase on main
  • Set change the default value of the autoremember timer from '' to 0.
  • Add Jasmine tests of setting-definitions and setting-accessors
  • Add setting-accessors:remove()

cxw42 added 2 commits February 16, 2025 15:46
@cxw42
Changelog: add request for help
a704a1a 
`Settings | What's New?` is still the only way I have of communicating
with TF users who aren't on GitHub.
@cxw42
Add new autoremember-timer-minutes setting (#316)
03a5228
@cxw42 cxw42 force-pushed the issue316-autosave-timer branch from c638b55 to 03a5228 Compare February 16, 2025 20:49
@cxw42
Copy link
Owner Author

cxw42 commented Feb 16, 2025

Force-push changes: replace 😅 with \u{} (gitk can't display emojis, so don't put any in the source.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cxw42 cxw42

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to remember tabs automatically on a schedule
2 participants
@cxw42 @andr222