Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basketball Add Moved as an Optional Output of Activity #581

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

JohnDiebold
Copy link
Contributor

This adds the moved activity in basketball (player moved to a different fantasy roster slot). It is an optional argument with default value of False so that existing usage is not affected.

@JohnDiebold
Copy link
Contributor Author

@cwendt94 I've tested this with a couple of my leagues. If there's other testing that needs to be done or things needing changing let me know.

Just to add some context for why I would find this useful. I have a MySQL database for each fantasy teams roster on each day of the season. I use that to sum each teams projected points for the week (this is a points league). I'd like to store the time of the last activity and compare it to when the table was last updated to know if I need to update the table because someone moved a player from or to the bench. Right now the activities only returns add/drops, not moves.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 15.78947% with 16 lines in your changes missing coverage. Please review.

Project coverage is 83.98%. Comparing base (8e131e7) to head (993d24b).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
espn_api/basketball/activity.py 12.50% 14 Missing ⚠️
espn_api/basketball/league.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
- Coverage   84.39%   83.98%   -0.42%     
==========================================
  Files          60       60              
  Lines        2243     2254      +11     
==========================================
  Hits         1893     1893              
- Misses        350      361      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@cwendt94 cwendt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments and small suggestions

espn_api/basketball/activity.py Outdated Show resolved Hide resolved
espn_api/basketball/activity.py Outdated Show resolved Hide resolved
espn_api/basketball/league.py Outdated Show resolved Hide resolved
@JohnDiebold
Copy link
Contributor Author

Changes from all suggestions made. Thanks for the review!

@cwendt94 cwendt94 merged commit 1c62e80 into cwendt94:master Oct 15, 2024
2 of 3 checks passed
@JohnDiebold JohnDiebold deleted the basketball-moved-activity branch October 15, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants