Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Basketball Category Acronyms in STATS_MAP #568

Merged
merged 7 commits into from
Sep 9, 2024

Conversation

martincham
Copy link
Contributor

ESPN allows for counting 36 different stats, but not every stat was mapped in constant.py. The API also fetches a few stats that aren't scorable in fantasy, but being mapped will improve readability of a players stat data structure. I updated"3PTM" and "3PTA" acronym to be consistent with ESPN's "3PM" and "3PA".

Countable stats found in ESPN League > Settings > Scoring:

  • Games Played (GP)
  • Games Started (GS)
  • Minutes (MIN)
  • Field Goals Made (FGM)
  • Field Goals Attempted (FGA)
  • Field Goals Missed (FGMI)
  • Field Goal Percentage (FG%)
  • Adjusted Field Goal Percentage (AFG%)
  • Free Throws Made (FTM)
  • Free Throws Attempted (FTA)
  • Free Throws Missed (FTMI)
  • Free Throw Percentage (FT%)
  • Three Pointers Made (3PM)
  • Three Pointers Attempted (3PA)
  • Three Pointers Missed (3PMI)
  • Three Point Percentage (3P%)
  • Offensive Rebounds (OREB)
  • Defensive Rebounds (DREB)
  • Rebounds (REB)
  • Assists (AST)
  • Assists To Turnover Ratio (A/TO)
  • Steals (STL)
  • Steals To Turnover Ratio (STR)
  • Blocks (BLK)
  • Turnovers (TO)
  • Ejections (EJ)
  • Flagrant Fouls (FF)
  • Personal Fouls (PF)
  • Technical Fouls (TF)
  • Disqualifications (DQ)
  • Double Doubles (DD)
  • Triple Doubles (TD)
  • Quadruple Doubles (QD)
  • Points (PTS)
  • Points Per Minute (PPM)
  • Team Wins (TW)

Non Fantasy Stats I added:

  • APG - Assists Per Game
  • BPG - Blocks Per Game
  • PPG - Points Per Game
  • RPG - Rebound Per Game
  • SPG - Steals Per Game
  • TOPG - Turnovers Per Game
  • 3PG - Threes Per Game
  • FTR - Free Throw Rate

ESPN does not establish acronyms for these, so I'm open to adjusting these.

I confirmed these stats with Lebron's 23-24 numbers, and checked fouls, ejection, and disqualifications against other players who had these stats.
lebron.json

@cwendt94
Copy link
Owner

cwendt94 commented Sep 9, 2024

This is great thanks for adding these stats!

@cwendt94
Copy link
Owner

cwendt94 commented Sep 9, 2024

Looks like one int test failed with the new naming/format. Would you be able to update that test

@martincham
Copy link
Contributor Author

martincham commented Sep 9, 2024

Looks like I had missed a '3PTM' in NINE_CAT_STATS. Updated to '3PM' and tests succeed now.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (428d155) to head (99a4906).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #568      +/-   ##
==========================================
- Coverage   84.32%   84.31%   -0.02%     
==========================================
  Files          60       60              
  Lines        2227     2231       +4     
==========================================
+ Hits         1878     1881       +3     
- Misses        349      350       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwendt94 cwendt94 merged commit 9a87e6e into cwendt94:master Sep 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants