Merge pull request #492 from cwendt94/past-league-team-name

Past Team Name Use New Field
cwendt94 · Oct 26, 2023 · e9b5420 · e9b5420
2 parents 67f1660 + 16bd6fb
commit e9b5420
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 15 deletions.
diff --git a/espn_api/baseball/team.py b/espn_api/baseball/team.py
@@ -8,10 +8,9 @@ class Team(object):
     def __init__(self, data, roster, schedule, year, **kwargs):
         self.team_id = data['id']
         self.team_abbrev = data['abbrev']
-        if year < 2023:
+        self.team_name = data.get('name', 'Unknown')
+        if self.team_name == 'Unknown':
             self.team_name = "%s %s" % (data.get('location', 'Unknown'), data.get('nickname', 'Unknown'))
-        else:
-            self.team_name = data.get('name', 'Unknown')
         self.division_id = data['divisionId']
         self.division_name = '' # set by caller
         self.wins = data['record']['overall']['wins']

diff --git a/espn_api/basketball/team.py b/espn_api/basketball/team.py
@@ -7,10 +7,9 @@ class Team(object):
     def __init__(self, data, roster, schedule, year, **kwargs):
         self.team_id = data['id']
         self.team_abbrev = data['abbrev']
-        if year < 2023:
+        self.team_name = data.get('name', 'Unknown')
+        if self.team_name == 'Unknown':
             self.team_name = "%s %s" % (data.get('location', 'Unknown'), data.get('nickname', 'Unknown'))
-        else:
-            self.team_name = data.get('name', 'Unknown')
         self.division_id = data['divisionId']
         self.division_name = '' # set by caller
         self.wins = data['record']['overall']['wins']

diff --git a/espn_api/football/team.py b/espn_api/football/team.py
@@ -5,10 +5,9 @@ class Team(object):
     def __init__(self, data, roster, schedule, year, **kwargs):
         self.team_id = data['id']
         self.team_abbrev = data['abbrev']
-        if year < 2023:
+        self.team_name = data.get('name', 'Unknown')
+        if self.team_name == 'Unknown':
             self.team_name = "%s %s" % (data.get('location', 'Unknown'), data.get('nickname', 'Unknown'))
-        else:
-            self.team_name = data.get('name', 'Unknown')
         self.division_id = data['divisionId']
         self.division_name = '' # set by caller
         self.wins = data['record']['overall']['wins']

diff --git a/espn_api/hockey/team.py b/espn_api/hockey/team.py
@@ -9,10 +9,9 @@ class Team(object):
     def __init__(self, data, roster, schedule, year, **kwargs):
         self.team_id = data['id']
         self.team_abbrev = data['abbrev']
-        if year < 2023:
+        self.team_name = data.get('name', 'Unknown')
+        if self.team_name == 'Unknown':
             self.team_name = "%s %s" % (data.get('location', 'Unknown'), data.get('nickname', 'Unknown'))
-        else:
-            self.team_name = data.get('name', 'Unknown')
         self.division_id = data['divisionId']
         self.division_name = ''  # set by caller
         self.wins = data['record']['overall']['wins']

diff --git a/espn_api/wbasketball/team.py b/espn_api/wbasketball/team.py
@@ -7,10 +7,9 @@ class Team(object):
     def __init__(self, data, roster, schedule, year, **kwargs):
         self.team_id = data['id']
         self.team_abbrev = data['abbrev']
-        if year < 2023:
+        self.team_name = data.get('name', 'Unknown')
+        if self.team_name == 'Unknown':
             self.team_name = "%s %s" % (data.get('location', 'Unknown'), data.get('nickname', 'Unknown'))
-        else:
-            self.team_name = data.get('name', 'Unknown')
         self.division_id = data['divisionId']
         self.division_name = '' # set by caller
         self.wins = data['record']['overall']['wins']