-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version command #157
Add version command #157
Conversation
I wonder who is going to remember to bump the version manually? And Git commit? Maybe it's a nice time to add |
@butuzov As they way things are now it would have to be a manual bump prior to release. Ideally there would be a way to automate this (I can look into goreleaser). Also let me know about git commit, I can try to add that as well. |
git commit is what @cweill was talking in #133 (comment) |
@butuzov I have added code to add the commit on this branch, however the issue is that it requires the following build to inject the git commit hash.
As I'm new to golang, is there a way to set a default build script/build options when calling go build? I attempted searching for something like this but came up empty-handed. I'll keep looking but if you have any ideas of a better way to implement this/ build this let me know! |
so work plan is next:
@cweill can maybe add anything he would like to see in the implementation of this feature, as an author and maintainer. |
@butuzov Ok I can look into this, but because |
Good that you asked! I learned this recently and haven't tested it yet. Usually, version should support "devel builds", with a fallback to something like |
@teddylear Thanks for this PR. I agree with @butuzov, we should aim to automate the version number increasing. I'm not familiar with the best way to do this in Go, but there must be some precedence out there. |
Let me keep working on this, but I'll close this PR for now while implementing these changes. |
Adding version command to show current version of gotests installed.
NOTE Had issue with tests failing intermittently locally (even on develop). Not sure what the issue, please let me know if this is a known issue or something I should make another ticket for. This only appears to be happening for the 1.16.x build.
#133