Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle $COMPOSER environment variable #493

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Handle $COMPOSER environment variable #493

merged 3 commits into from
Feb 27, 2023

Conversation

cweagans
Copy link
Owner

Description

Closes #490.

Related tasks

  • Documentation has been updated if applicable
  • Tests have been added
  • Does not break backwards compatibility OR a BC break has been discussed in the related issue(s).

@cweagans cweagans mentioned this pull request Feb 26, 2023
Closed
3 tasks
@coveralls
Copy link

coveralls commented Feb 26, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4279317585

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 88.908%
Totals Coverage Status
Change from base Build 4279037707: 0.3%
Covered Lines: 521
Relevant Lines: 586
💛 - Coveralls

@cweagans
Copy link
Owner Author

@Sweetchuck Merging this, but lmk if it needs changes.

@cweagans cweagans closed this Feb 27, 2023
@cweagans cweagans reopened this Feb 27, 2023
@cweagans cweagans merged commit 7df092f into main Feb 27, 2023
@cweagans cweagans deleted the 490-composer-env-var branch February 27, 2023 05:43
@Sweetchuck
Copy link
Contributor

Thank you. Basically this is what I wanted.

  • Patches lock file name ends with *.json
  • Patches lock file somehow attached to the composer.lock

Both objective are done. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

COMPOSER environment variable vs patches.lock
3 participants
@cweagans @coveralls @Sweetchuck