Fix #408: Support proxies #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danepowell can you look over this? I've noticed that @cweagans appears to not look into this repository frequently and hope you have the rights to merge here? |
danepowell
changed the title
danepowell
approved these changes
Jan 23, 2023
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #408
Motivation:
Composer supports socks5 proxy, we want the same support in patching.
Approach:
We are currently using a streamer RemoteFilesystem.php, which doesn't support
socks5orsocks5hbecause of protocol limitation. However, we don't really need a streamer, we simply want to download the patch file and move on. So, using a downloader makes sense.