Add a method to tell if a package has been patched #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cweagans
approved these changes
Jan 25, 2022
|
Note that if you want this in a release any time soon, this will also need to go into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the purposes of Drupal's auto-updates initiative, it would be really useful to us to have an API method in this plugin which can tell us if an installed package has been patched. We could just check the presence of the
extra.patches_appliedkey -- and indeed, we do -- but we'd rather the plugin exposed an API for this, so we don't have to rely on internal keys. So this PR adds aPatch::isPackagePatched()method for this purpose.See related discussion in https://www.drupal.org/project/automatic_updates/issues/3252299.