Fix for outdated patch version on FreeBSD #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requires PHP 7.2
|
+1 this helps me on FreeBSD |
|
Thank you for this! I missed this when you opened it. This is a very nice, safe way to accomplish what you need. Really appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
There are many issues about this topic and many tried to get a fix into the repo.
#184 This is one of the biggest pull request - it got rejected because of many reasons. Many changed to another project to fix it.
So my approach is to use the
--posix --batchonly when the OS is BSD. That shouldn't break anything and makes everyone happy.Even Travis is happy
@cweagans Please let me know what you think about this approach. Will then submit a fix for 1.x too