Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ext-json in composer.json. #248

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Add missing ext-json in composer.json. #248

merged 2 commits into from
Feb 14, 2019

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Jan 25, 2019

We are using the PHP function json_decode in some places in the code.

Therefore, we need to ensure that users has the proper PHP extension "ext-json".

In order to do that, we need to modify the composer.json and add

"ext-json": "*"

in the require section.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 38.276% when pulling 50899fb on drupol:add-missing-php-extension into d3b9741 on cweagans:master.

@drupol
Copy link
Contributor Author

drupol commented Feb 14, 2019

@cweagans Could you review this ?

@cweagans cweagans merged commit d8a38a5 into cweagans:master Feb 14, 2019
@drupol
Copy link
Contributor Author

drupol commented Feb 14, 2019

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants