Remove patch report generation #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donquixote
pushed a commit
to donquixote/composer-patches
that referenced
this pull request
Mar 15, 2019
This is a backport of pull request cweagans#213 for issue cweagans#140. The two commits from cweagans#213 have been squashed into one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm removing patch report generation and it's related config option because it's not necessary. Because the plugin will dispatch events before and after applying each patch, it's possible to generate this in a separate plugin if that's desired.
I also plan to add a
composer patch-listcommand (which optionally accepts a package name as an argument) so that users will be able to see which patches are applied.#140 also points out that PATCHES.txt might be a minor security risk in some cases, so it's better to just leave this out of the plugin entirely.