Split out patch resolution into Composer Capabilities #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cweagans
force-pushed
the
resolver-capabilities
branch
from
1c1d287 to
4a946db
Compare
Repository owner
deleted a comment from
coveralls
May 18, 2018
|
The fact that the tests are currently passing is not a good thing. Shows how inadequate the test coverage is currently 😢 |
…of Drupal that doesn't have .ht.router.php
|
The coveralls error is interesting. This PR increases coverage from ~7% to ~32% if I'm not mistaken. |
ryanaslett
reviewed
Jun 2, 2018
src/Resolvers/PatchesFile.php
Outdated
| $patches = json_decode($patches, true); | ||
|
|
||
| // First, check for JSON syntax issues. | ||
| $error = json_last_error(); |
There was a problem hiding this comment.
Seems like you could use php's json_last_error_msg() and skip this whole switch/case statement below.
There was a problem hiding this comment.
Good call. The current plugin has this big switch/case statement because it supports earlier versions of PHP. I'm only planning on supporting 5.6+ for 2.0.0, so json_last_error_msg() sounds great :) Thanks for catching that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables users to extend patch resolution in their own plugin. This would allow someone to essentially define their own logic for finding patches to apply to a package.
A lot of this code was ported out of the 2.x-prototype branch.
Remaining tasks:
checkPatches()working again. Since we're now resolving patches before the first package is installed/updated, checkPatches() doesn't have any of that data. The obvious solution is to run patch resolution earlier, but that might be tricky.