Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --git-dir instead of GIT_DIR env variable #108

Merged
merged 1 commit into from
Mar 19, 2017
Merged

Use --git-dir instead of GIT_DIR env variable #108

merged 1 commit into from
Mar 19, 2017

Conversation

daften
Copy link
Contributor

@daften daften commented Feb 26, 2017

Fixes #106 with another method than #107
This works on unix, but would need to be tested on windows, I'm hoping @david-garcia-garcia and @celston can help with that? :)

@david-garcia-garcia
Copy link
Contributor

I tried the command syntax directly on the console, and it - at least- does not break on windows. Still not sure why we need to use --git-dir at all. We are cd'ing in order to place ourselves in the directory where the git root is supposed to be.

@cweagans
Copy link
Owner

Sometimes there is no git root (i.e. if installing from dist). I prefer this pr over #107, fwiw.

@daften
Copy link
Contributor Author

daften commented Feb 28, 2017

Yes, if there's no git root inside the package to be patched, this makes sure that's possible.
This is my preferred option too, since it should work cross platform, but it only came to me after I made the other PR :)

@dmsmidt
Copy link

dmsmidt commented Mar 14, 2017

This should get top priority, without it patching on Linux is broken.
I tested manually on Linux and it works.

dmsmidt pushed a commit to Triquanta/composer-patches that referenced this pull request Mar 14, 2017
@REBELinBLUE
Copy link

Any update on this? Patching is completely broken when trying to patch dist packages

@cweagans cweagans merged commit b3036f2 into cweagans:master Mar 19, 2017
@REBELinBLUE
Copy link

:D Thanks @cweagans

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants