Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State that it's the MIT #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mgifford
Copy link

Just thought that you should state the license here, rather than just the text. Easiest would just be to point folks to the License file, but doesn't make sense to just include the text of the license, under the name.

Just thought that you should state the license here, rather than just the text.  Easiest would just be to point folks to the License file, but doesn't make sense to just include the text of the license, under the name.
@jrpool
Copy link
Collaborator

jrpool commented Jul 19, 2024

Thank you for pointing out this omission. The license statements were added to this file and all Node.js code files per instructions from the new copyright holder upon transfer of the copyright. I shall ask the copyright holder whether the omission of “MIT License” everywhere except in the license file is required. If not, then I agree with you that it is helpful to include it, and not only in the README file. So I’m leaving this PR open until I get a response.

@poolcvs
Copy link
Collaborator

poolcvs commented Jul 25, 2024

I have obtained approval to insert “MIT License” as you propose. There are 175 files with the license text in them, and I have added “MIT License” to them all, but I prefer to merge your PR in order to get the “## License” into the README.md file. Are you willing to complete the contribution license agreement, so I can do this? It is at:
https://forms.office.com/pages/responsepage.aspx?id=uGG7-v46dU65NKR_eCuM1xbiih2MIwxBuRvO0D_wqVFUQ1k0OE5SVVJWWkY4MTVJMkY3Sk9GM1FHRC4u

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants