New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of _trackDb is improper in annotation.js #44

Closed

bctcvai opened this issue Jan 7, 2020 · 0 comments

Labels

good first issue

Milestone

Member

bctcvai commented Jan 7, 2020

TrackDb object is a map, but object accessors ([]) are used. Instead https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/set and https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/get should be used.

tator/main/static/js/annotator/annotation.js

Line 581 in 0ea0846

this._data._trackDb[localId] = track;

bctcvai added the good first issue label

bctcvai added this to the 1.1.0 milestone

bctcvai added a commit that referenced this issue


          Fix usage of '_trackDb', closes #44.

ee78ca0

bctcvai closed this as completed in

a633103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment