Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag numpy 1.26.4 to be compatible with Open3D. Support Python 3.11 #114

Merged
merged 7 commits into from
Jan 7, 2025
Merged

Tag numpy 1.26.4 to be compatible with Open3D. Support Python 3.11 #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9c0922b
fix open3d issue
B1ueber2y Jan 6, 2025
9751fb2
support python 3.11 due to open3d upgrade
B1ueber2y Jan 6, 2025
418899f
format
B1ueber2y Jan 6, 2025
f06b6cd
Merge branch 'main' into fix/open3d
B1ueber2y Jan 6, 2025
dd2b659
back compatibility for python 3.8
B1ueber2y Jan 6, 2025
d1a0e1f
Merge branch 'main' into fix/open3d
MarkYu98 Jan 7, 2025
752315c
Merge branch 'main' into fix/open3d
B1ueber2y Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
{os: ubuntu-latest, python-version: "3.8"},
{os: ubuntu-latest, python-version: "3.9"},
{os: ubuntu-latest, python-version: "3.10"},
{os: ubuntu-latest, python-version: "3.11"},
]
env:
COMPILER_CACHE_VERSION: 1
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ In this project, we provide interfaces for various geometric operations on 2D/3D
## Installation

**Install the dependencies as follows:**
* Python 3.8/9/10
* Python 3.8/9/10/11
* CMake >= 3.17
* CUDA (for deep learning based detectors/matchers)
* System dependencies [[Command line](./misc/install/dependencies.md)]
Expand Down
8 changes: 5 additions & 3 deletions limap/visualize/vis_lines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,11 @@ def open3d_get_line_set(lines, color=None, ranges=None, scale=1.0):
counter += 1
o3d_colors.append(color)
line_set = o3d.geometry.LineSet()
line_set.points = o3d.utility.Vector3dVector(o3d_points)
line_set.lines = o3d.utility.Vector2iVector(o3d_lines)
line_set.colors = o3d.utility.Vector3dVector(o3d_colors)
line_set.points = o3d.utility.Vector3dVector(np.array(o3d_points))
line_set.lines = o3d.utility.Vector2iVector(
np.array(o3d_lines).astype(np.int32)
)
line_set.colors = o3d.utility.Vector3dVector(np.array(o3d_colors))
return line_set


Expand Down
4 changes: 2 additions & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ pyyaml
tqdm
attrdict
h5py
numpy
scipy
matplotlib
seaborn
Expand All @@ -16,11 +15,12 @@ pyvista
omegaconf
plyfile
pathlib
open3d==0.16.0
imagesize
einops
ninja
yacs
numpy<=1.26.4 # Tag numpy 1.26.4 for Open3D issue (https://github.com/numpy/numpy/issues/26853)
open3d==0.18.0
pycolmap>=3.11.1
ruff==0.6.7
clang-format==19.1.0
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def build_extension(self, ext):
name="limap",
version="1.0.0",
packages=find_packages(),
python_requires=">=3.8, < 3.11",
python_requires=">=3.8, < 3.12",
author="Shaohui Liu",
author_email="b1ueber2y@gmail.com",
description="A toolbox for mapping and localization with line features",
Expand Down
Loading