Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor release artifact directory structure and update changelog ge… #90

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

cvele
Copy link
Owner

@cvele cvele commented Oct 14, 2024

…neration

Summary by Sourcery

Refactor the release artifact directory structure by removing the 'translations' directory from the release package and update the changelog generation process in the CI workflow to use the latest tag.

Enhancements:

  • Refactor the release artifact directory structure by removing the 'translations' directory from the release package.

CI:

  • Update the changelog generation in the 'new_version_pr.yml' workflow to use the latest tag for determining changes.

Copy link

sourcery-ai bot commented Oct 14, 2024

Reviewer's Guide by Sourcery

This pull request refactors the release artifact directory structure and updates the changelog generation process. The changes focus on improving the CI/CD pipeline by modifying how the changelog is generated and simplifying the release artifact structure.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update changelog generation to use LATEST_TAG environment variable
  • Replace git command with LATEST_TAG environment variable for determining the since-tag
  • Simplify the changelog generation process in the CI workflow
.github/workflows/new_version_pr.yml
Simplify release artifact structure
  • Remove copying of translations directory to release artifact
  • Streamline the release artifact creation process
.github/workflows/create_release_tag.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@cvele cvele enabled auto-merge (squash) October 14, 2024 13:38
@cvele
Copy link
Owner Author

cvele commented Oct 14, 2024

@sourcery-ai review

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cvele - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@cvele cvele merged commit 1f807a6 into main Oct 14, 2024
6 checks passed
@cvele cvele deleted the fix/release-action-2 branch October 14, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant