Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create multiple tasks when uploading multiple videos #4824

Merged
merged 41 commits into from
Sep 13, 2022
Merged

Create multiple tasks when uploading multiple videos #4824

merged 41 commits into from
Sep 13, 2022

Conversation

AlexeyAlexeevXperienceAI
Copy link
Contributor

@AlexeyAlexeevXperienceAI AlexeyAlexeevXperienceAI commented Aug 24, 2022 •
edited by bsekachev
Loading

Motivation and context

Resolve #916

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@AlexeyAlexeevXperienceAI AlexeyAlexeevXperienceAI force-pushed the aa/creating-multiple-tasks-uploading-videos branch from e664b24 to a42d531 Compare August 24, 2022 10:34
@AlexeyAlexeevXperienceAI
Copy link
Contributor Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022 •
edited
Loading

❌ Some checks failed
📄 See logs here

@AlexeyAlexeevXperienceAI
Copy link
Contributor Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2022 •
edited
Loading

❌ Some checks failed
📄 See logs here

@AlexeyAlexeevXperienceAI AlexeyAlexeevXperienceAI force-pushed the aa/creating-multiple-tasks-uploading-videos branch from 2c36549 to 77961d4 Compare August 26, 2022 15:40
@AlexeyAlexeevXperienceAI AlexeyAlexeevXperienceAI changed the title [WIP] Create multiple tasks when uploading multiple videos Create multiple tasks when uploading multiple videos Aug 29, 2022
@AlexeyAlexeevXperienceAI AlexeyAlexeevXperienceAI marked this pull request as ready for review August 29, 2022 11:52
@AlexeyAlexeevXperienceAI
Copy link
Contributor Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2022 •
edited
Loading

❌ Some checks failed
📄 See logs here

@bsekachev
Copy link
Member

Hi, Here are some implementation issues/ideas I came across:

  • That is not really obvious how to see these template rules.
    I would suggest adding an QuestionCircle icon with this tooltip, or maybe somehow highlight "template" word (making it a hyperlink style?)
    image

  • Let's add spaces here. BTW, how do pending work? It is always 0 for me, even if I create several tasks with 1 rq worker.
    image

  • I am not sure we need this pop-up notification, looks useless because we have a progress bar near the submit button:
    image

  • Can we somehow escape Database is locked on development environment?

  • I was able to create a task with .png file (but if I select several .png files, I can't):
    image

  • When created tasks from connected file share, I have extra slash at the begging of a task name:
    image

  • Where Cloud storage option is?
    image

  • With remote sources I also can submit tasks with .jpeg files:
    image

  • Strange scenario:

  1. Put two links (to images) to Remote sources
  2. It shows the error (Only bulk of videos)
  3. Remove one of links
  4. The error disappears
  5. Press "Submit 1 task" button
  6. It shows progress bar with 2 tasks
  7. One of tasks creation fails and UI is fails
    image
  8. The second task with an image is successfully created

@bsekachev
Copy link
Member

Could you please provide any source & license for multi-plus-icon.svg?
Usually if we get icons outside, we put source & license to the beginning of .svg file.

@AlexeyAlexeevXperienceAI
Copy link
Contributor Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022 •
edited
Loading

❌ Some checks failed
📄 See logs here

@AlexeyAlexeevXperienceAI AlexeyAlexeevXperienceAI changed the title Create multiple tasks when uploading multiple videos [WIP] Create multiple tasks when uploading multiple videos Sep 9, 2022
@cvat-ai cvat-ai deleted a comment from github-actions bot Sep 11, 2022
@bsekachev
Copy link
Member

/check

@cvat-ai cvat-ai deleted a comment from github-actions bot Sep 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2022 •
edited
Loading

🚫 Workflows has been canceled
📄 See logs here

@cvat-ai cvat-ai deleted a comment from github-actions bot Sep 13, 2022
@sizov-kirill
Copy link
Contributor

@bsekachev I closed full check, because e2e tests was executing extremely long. I need some time to investigate it.

@bsekachev
Copy link
Member

@kirill-sizov

Why do you think so, current run took about 25 minutes, yesterday as I noticed GitHub had service issues.

@sizov-kirill
Copy link
Contributor

/check

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2022 •
edited
Loading

❌ Some checks failed
📄 See logs here

@bsekachev
Copy link
Member

UX issues I currently see:

  • In the shared storage we are able to check directories, it leads to errors (see my comment above)
  • 'Cancel' button does not work for a task which is in progress

@bsekachev
Copy link
Member

/check

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2022 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

@bsekachev bsekachev changed the title [WIP] Create multiple tasks when uploading multiple videos Create multiple tasks when uploading multiple videos Sep 13, 2022
@cvat-ai cvat-ai deleted a comment from github-actions bot Sep 13, 2022
@cvat-ai cvat-ai deleted a comment from github-actions bot Sep 13, 2022
@bsekachev
Copy link
Member

/check

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2022 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

@cvat-ai cvat-ai deleted a comment from github-actions bot Sep 13, 2022
@bsekachev bsekachev merged commit 1db247a into develop Sep 13, 2022
@bsekachev bsekachev mentioned this pull request Sep 13, 2022
Closed
@bsekachev bsekachev deleted the aa/creating-multiple-tasks-uploading-videos branch September 14, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsekachev bsekachev bsekachev left review comments

@azhavoro azhavoro Awaiting requested review from azhavoro azhavoro is a code owner

@nmanovic nmanovic Awaiting requested review from nmanovic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a lot of tasks with videos at the same time
3 participants
@AlexeyAlexeevXperienceAI @bsekachev @sizov-kirill