Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update item Annotation with polygons in User guide #1559

Conversation

TOsmanov
Copy link
Contributor

@TOsmanov TOsmanov commented May 19, 2020

Motivation and context

This PR contains update of the text, images and gif of the Annotation with polygons item.
The item "Annotation with auto-segmentation" is transferred to the item "Make AI polygon".
And also adds description drawing using automatic borders.

The following measures were taken to solve problem #1447:

gif005_DETRAC.gif and gif009_DETRAC.gif has a reduced size.

How has this been tested?

N/A

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@TOsmanov TOsmanov requested a review from nmanovic as a code owner May 19, 2020 09:40
@coveralls
Copy link

coveralls commented May 19, 2020

Pull Request Test Coverage Report for Build 5319

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 190 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.05%) to 65.701%

Files with Coverage Reduction New Missed Lines %
src/annotations-objects.js 4 58.76%
cvat/apps/dataset_manager/bindings.py 5 93.24%
cvat/apps/engine/media_extractors.py 5 77.65%
cvat/apps/log_viewer/views.py 6 0%
datumaro/datumaro/cli/main.py 31 0%
cvat/apps/auto_segmentation/views.py 60 0%
cvat/apps/git/git.py 79 16.12%
Totals Coverage Status
Change from base Build 5163: 0.05%
Covered Lines: 10847
Relevant Lines: 16109

💛 - Coveralls

@TOsmanov TOsmanov mentioned this pull request May 19, 2020
55 tasks
- After closing the polygon, you can select the part of the polygon that you want to leave.
- You can press ``Esc`` to cancel editing.

![](static/documentation/images/gif007_mapillary_vistas.gif)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TOsmanov , could you please check that all images are visible next time (press view file and inspect it)? Image file names are case sensitive. I will recommend to rename all files in lowercase.

P.S. You probably don't see the issue on Windows because file names on Windows are case insensitive. Thus you need to check the user_guide.md here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmanovic , yes it is, I corrected the file names and paths in PR #1596 , to them so that they did not contain uppercase letters.

nmanovic
nmanovic previously approved these changes May 27, 2020
@nmanovic
Copy link
Contributor

@TOsmanov , need to fix the PR. After you renamed all files it isn't correct anymore.

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic
Copy link
Contributor

@TOsmanov , need to resolve conflicts.

@TOsmanov
Copy link
Contributor Author

@nmanovic , one of the conflict files is "gif009_detrac.gif", I don’t know how to resolve such a conflict

@TOsmanov
Copy link
Contributor Author

@nmanovic , I created a new PR #1612 , it has no conflicts

@TOsmanov TOsmanov closed this May 28, 2020
@TOsmanov TOsmanov deleted the UG-update-item-Annotation-with-polygons branch June 24, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants