-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use github actions to build Windows releases for pypi #33
Open
cmacdonald
wants to merge
58
commits into
cvangysel:master
Choose a base branch
from
terrierteam:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change suffix, target real pypi for release.
github actions no longer support py3.6
fix multiple invocation problem
bump version for release
add judged_docs_only_flag
Also, move to build, pyproject.toml etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @cvangysel please consider this PR for making binary Windows releases using GitHub actions.
I have test this using Github actions on my own fork to make a test pypi release.
To use this, you would need to:
$Env:PYTRECEVAL_NAME_SUFFIX = "-craigm"
I further made the following changes:
__init__.py
, and copied into setup.pyYou may wish to consider if you want to also build other binary wheel releases at this time (linux etc).
An in principle response would be appreciated - we need to have this for teaching commitments this summer.
Craig