Skip to content

Commit

Permalink
rollup merge of #20215: csouth3/hashmap-rename
Browse files Browse the repository at this point in the history
Rename struct `Entries` to `Iter` in hash/table.rs and hash/map.rs, to match the naming convention of rust-lang/rfcs#344.

This is a [breaking-change].
  • Loading branch information
alexcrichton committed Dec 30, 2014
2 parents e6aa746 + 8a384f7 commit 7c22508
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
14 changes: 7 additions & 7 deletions map.rs
Original file line number Diff line number Diff line change
Expand Up @@ -896,8 +896,8 @@ impl<K: Eq + Hash<S>, V, S, H: Hasher<S>> HashMap<K, V, H> {
/// }
/// ```
#[unstable = "matches collection reform specification, waiting for dust to settle"]
pub fn iter(&self) -> Entries<K, V> {
Entries { inner: self.table.iter() }
pub fn iter(&self) -> Iter<K, V> {
Iter { inner: self.table.iter() }
}

/// An iterator visiting all key-value pairs in arbitrary order,
Expand Down Expand Up @@ -1313,8 +1313,8 @@ impl<K: Hash<S> + Eq, Sized? Q, V, S, H: Hasher<S>> IndexMut<Q, V> for HashMap<K
}

/// HashMap iterator
pub struct Entries<'a, K: 'a, V: 'a> {
inner: table::Entries<'a, K, V>
pub struct Iter<'a, K: 'a, V: 'a> {
inner: table::Iter<'a, K, V>
}

/// HashMap mutable values iterator
Expand All @@ -1334,12 +1334,12 @@ pub struct IntoIter<K, V> {

/// HashMap keys iterator
pub struct Keys<'a, K: 'a, V: 'a> {
inner: Map<(&'a K, &'a V), &'a K, Entries<'a, K, V>, fn((&'a K, &'a V)) -> &'a K>
inner: Map<(&'a K, &'a V), &'a K, Iter<'a, K, V>, fn((&'a K, &'a V)) -> &'a K>
}

/// HashMap values iterator
pub struct Values<'a, K: 'a, V: 'a> {
inner: Map<(&'a K, &'a V), &'a V, Entries<'a, K, V>, fn((&'a K, &'a V)) -> &'a V>
inner: Map<(&'a K, &'a V), &'a V, Iter<'a, K, V>, fn((&'a K, &'a V)) -> &'a V>
}

/// HashMap drain iterator
Expand Down Expand Up @@ -1381,7 +1381,7 @@ enum VacantEntryState<K, V, M> {
NoElem(EmptyBucket<K, V, M>),
}

impl<'a, K, V> Iterator<(&'a K, &'a V)> for Entries<'a, K, V> {
impl<'a, K, V> Iterator<(&'a K, &'a V)> for Iter<'a, K, V> {
#[inline] fn next(&mut self) -> Option<(&'a K, &'a V)> { self.inner.next() }
#[inline] fn size_hint(&self) -> (uint, Option<uint>) { self.inner.size_hint() }
}
Expand Down
8 changes: 4 additions & 4 deletions table.rs
Original file line number Diff line number Diff line change
Expand Up @@ -657,8 +657,8 @@ impl<K, V> RawTable<K, V> {
}
}

pub fn iter(&self) -> Entries<K, V> {
Entries {
pub fn iter(&self) -> Iter<K, V> {
Iter {
iter: self.raw_buckets(),
elems_left: self.size(),
}
Expand Down Expand Up @@ -770,7 +770,7 @@ impl<'a, K, V> Iterator<(K, V)> for RevMoveBuckets<'a, K, V> {
}

/// Iterator over shared references to entries in a table.
pub struct Entries<'a, K: 'a, V: 'a> {
pub struct Iter<'a, K: 'a, V: 'a> {
iter: RawBuckets<'a, K, V>,
elems_left: uint,
}
Expand All @@ -793,7 +793,7 @@ pub struct Drain<'a, K: 'a, V: 'a> {
iter: RawBuckets<'static, K, V>,
}

impl<'a, K, V> Iterator<(&'a K, &'a V)> for Entries<'a, K, V> {
impl<'a, K, V> Iterator<(&'a K, &'a V)> for Iter<'a, K, V> {
fn next(&mut self) -> Option<(&'a K, &'a V)> {
self.iter.next().map(|bucket| {
self.elems_left -= 1;
Expand Down

0 comments on commit 7c22508

Please sign in to comment.