Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cautionaryPitchClass=True work with chords #183

Merged
merged 2 commits into from
May 10, 2022
Merged

Make cautionaryPitchClass=True work with chords #183

merged 2 commits into from
May 10, 2022

Conversation

jacobtylerwalls
Copy link
Member

Partial port of cuthbertLab/music21#1299

@jacobtylerwalls jacobtylerwalls requested a review from vanderstel May 9, 2022 17:30
vanderstel
vanderstel approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@vanderstel vanderstel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vanderstel vanderstel merged commit 7b59588 into master May 10, 2022
@vanderstel vanderstel deleted the cautionary-accidental-in-chord branch May 10, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanderstel vanderstel vanderstel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobtylerwalls @vanderstel