Merge pull request #181 from jacobtylerwalls/sharps-setter

Fix clearing of alteredPitches when setting sharps
cuthbertLab · Apr 29, 2022 · e2e781d · e2e781d
2 parents b46230e + 20e5926
commit e2e781d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/key.ts b/src/key.ts
@@ -95,7 +95,7 @@ export class KeySignature extends base.Music21Object {
     }
 
     set sharps(s: number) {
-        this._alteredPitchesCache = [];
+        this._alteredPitchesCache = undefined;
         this._sharps = s;
     }
 

diff --git a/tests/moduleTests/key.ts b/tests/moduleTests/key.ts
@@ -62,4 +62,10 @@ export default function tests() {
 
         assert.equal(k.width, 42, 'checking width');
     });
+
+    test('music21.key.KeySignature setting sharps updates alteredPitches', assert => {
+        const ks = new music21.key.KeySignature();
+        ks.sharps = -4;
+        assert.equal(`${ks.alteredPitches.map(p => p.name)}`, 'B-,E-,A-,D-');
+    });
 }