Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export stem styles on notes with implicit stem directions #1725

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

jacobtylerwalls
Copy link
Member

Before
Stem styles were only exported if a stemDirection was explicit.

Now
If a stem has style information, the stem direction is calculated and the stem element is written with style info.

Fixes #1724

@mscuthbert mscuthbert closed this Sep 17, 2024
@mscuthbert mscuthbert reopened this Sep 17, 2024
@mscuthbert
Copy link
Member

closing and reopening to get a clean board with the new pinned versions of dependents

@mscuthbert
Copy link
Member

Wonderful. Thank you Jacob!

@mscuthbert mscuthbert merged commit 7726e66 into master Sep 17, 2024
8 of 12 checks passed
@mscuthbert mscuthbert deleted the jtw/stem-style-without-direction branch September 17, 2024 10:49
@coveralls
Copy link

Coverage Status

coverage: 93.018%. remained the same
when pulling 08cd3db on jtw/stem-style-without-direction
into 2c346ec on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stem styles aren't exported unless stemDirection is explicit
3 participants